Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-09-02 16:38:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolve external images through the target mount namespace.

Browse Source 
The image paths from /proc/<pid>/maps are only valid in the target's
mount namespace, so resolve them through /proc/<pid>/root (proc(5)). For
unlinked images the kernel keeps the bytes alive in the mapping's
map_files entry, which is opened directly instead.
This commit is contained in:
Bartosz Taudul
2026-08-30 16:12:39 +02:00
parent d352907e5d
commit bd1d783017
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
public/client/TracyCallstack.cpp
View File

@@ -376,9 +376,28 @@ static bool s_extImagesSorted = true;
// a full re-parse on every symbolization.
static int64_t s_lastMapsRefresh = 0;
static uint64_t ReadElfMinLoadVaddr( const char* path )
static int MakeExternalTargetPath( char* buf, size_t bufSize, const char* targetPath )
{
int fd = open( path, O_RDONLY );
const int n = snprintf( buf, bufSize, "/proc/%d/root%s", (int)s_externalTargetPid, targetPath );
return ( n < 0 || (size_t)n >= bufSize ) ? -1 : n;
}
static int OpenExternalImageFile( const char* path, uint64_t mapStart, uint64_t mapEnd )
{
char rootPath[4096];
if( MakeExternalTargetPath( rootPath, sizeof( rootPath ), path ) >= 0 )
{
const int fd = open( rootPath, O_RDONLY );
if( fd >= 0 ) return fd;
}
char mfPath[80];
snprintf( mfPath, sizeof( mfPath ), "/proc/%d/map_files/%lx-%lx", (int)s_externalTargetPid, (unsigned long)mapStart, (unsigned long)mapEnd );
return open( mfPath, O_RDONLY );
}
static uint64_t ReadElfMinLoadVaddr( const char* path, uint64_t mapStart, uint64_t mapEnd )
{
const int fd = OpenExternalImageFile( path, mapStart, mapEnd );
if( fd < 0 ) return UINT64_MAX;
elf_ehdr ehdr;
@@ -447,7 +466,7 @@ static void ParseExternalProcMaps( pid_t pid )
if( plen == 0 || pathname[0] != '/' ) continue;
if( std::find_if( s_extImages->begin(), s_extImages->end(), [start]( const ExternalImageEntry& e ) { return e.startAddress == start; } ) != s_extImages->end() ) continue;
uint64_t minVaddr = ReadElfMinLoadVaddr( pathname );
uint64_t minVaddr = ReadElfMinLoadVaddr( pathname, start, end );
uint64_t loadBias;
if( minVaddr == UINT64_MAX )
{