From f6965c62a97a87f3b9d214e515ae34a2cafa092f Mon Sep 17 00:00:00 2001 From: Marcos Slomp Date: Tue, 2 Dec 2025 10:54:08 -0800 Subject: [PATCH] reminder --- public/client/TracySysTrace.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/public/client/TracySysTrace.cpp b/public/client/TracySysTrace.cpp index cb1974e3..a0323800 100644 --- a/public/client/TracySysTrace.cpp +++ b/public/client/TracySysTrace.cpp @@ -147,6 +147,10 @@ void WINAPI EventRecordCallback( PEVENT_RECORD record ) #endif const auto& hdr = record->EventHeader; + // WARN: doing a fast switch-match below with the top 32 bits of the GUID + // (Data1 is the leading 32bit word of the 128bit GUID). + // Ideally, we should be using 'IsEqualGUID()' inside each case match to be + // inequivocally sure we are dealing the correct event provider. switch( hdr.ProviderId.Data1 ) { case etw::ThreadGuid.Data1: