Scarfski/assimp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[OpenGEX] disable partial implementation of light import (causes model load failure) (#6044)

Browse Source 
* Disable OpenGEX lights and cameras which are suspected of causing model load failure

* Revert changes to camera import

---------

Co-authored-by: tellypresence <praktique-tellypresence@yahoo.com>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
This commit is contained in:
Steve M
2025-03-16 05:32:17 -07:00
committed by GitHub
parent 2690e354da
commit a93b9f8c80
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
code/AssetLib/OpenGEX/OpenGEXImporter.cpp
View File

@@ -310,7 +310,8 @@ void OpenGEXImporter::InternReadFile(const std::string &filename, aiScene *pScen
copyMeshes(pScene);
copyCameras(pScene);
copyLights(pScene);
// TODO: lights only partially implemented and breaking model import
// copyLights(pScene);
copyMaterials(pScene);
resolveReferences();
createNodeTree(pScene);
@@ -366,7 +367,8 @@ void OpenGEXImporter::handleNodes(DDLNode *node, aiScene *pScene) {
break;
case Grammar::LightNodeToken:
handleLightNode(*it, pScene);
// TODO: lights only partially implemented and breaking model import
// handleLightNode(*it, pScene);
break;
case Grammar::GeometryObjectToken:
@@ -378,7 +380,8 @@ void OpenGEXImporter::handleNodes(DDLNode *node, aiScene *pScene) {
break;
case Grammar::LightObjectToken:
handleLightObject(*it, pScene);
// TODO: lights only partially implemented and breaking model import
// handleLightObject(*it, pScene);
break;
case Grammar::TransformToken:
@@ -468,7 +471,10 @@ void OpenGEXImporter::handleNameNode(DDLNode *node, aiScene * /*pScene*/) {
}
const std::string name(val->getString());
if (m_tokenType == Grammar::GeometryNodeToken || m_tokenType == Grammar::LightNodeToken || m_tokenType == Grammar::CameraNodeToken) {
if (m_tokenType == Grammar::GeometryNodeToken ||
// TODO: lights only partially implemented and breaking model import
// m_tokenType == Grammar::LightNodeToken ||
m_tokenType == Grammar::CameraNodeToken) {
m_currentNode->mName.Set(name.c_str());
} else if (m_tokenType == Grammar::MaterialToken) {
aiString aiName;