Scarfski/basis_universal
1
0
Fork 0
mirror of https://github.com/BinomialLLC/basis_universal.git synced 2026-09-14 14:38:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

updating per-channel weight comment

Browse Source
This commit is contained in:
Richard Geldreich
2026-07-03 22:12:26 -04:00
parent bbc49c63a8
commit 984978bb2c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
encoder/basisu_comp.h
View File

@@ -464,7 +464,8 @@ namespace basisu
m_xuastc_ldr_debug_block_x.clear();
m_xuastc_ldr_debug_block_y.clear();
// 4/26/2026: The default ASTC/XUASTC LDR channel weights are now 9,11,1 - this looks a lot better for photos vs. 1,1,1.
// 4/26/2026: The default ASTC/XUASTC/XUBC7/DDS creation LDR channel weights are now 9,11,1 - this looks a lot better for photos vs. 1,1,1.
// The challenge with this new default: developers compressing normal maps or non-sRGB content must now override these channel weights to 1,1,1,1.
set_xuastc_ldr_srgb_channel_weights(true);
m_xuastc_ldr_blurring.clear();
@@ -862,7 +863,7 @@ namespace basisu
// Entropy coding syntax: Default is basist::astc_ldr_t::xuastc_ldr_syntax::cFullZstd (fastest transcoding but lower ratio).
param<int> m_xuastc_ldr_syntax;
// XUASTC/XUBC7 weights (TODO: rename to make it clear these are shared between different codecs now)
// ASTC/XUASTC/XUBC7 weights - these per-channel weights are also used when encoding .DDS files
// Each component channel weight must be >= 1 (no 0 weights allowed).
// Important: Default channel weights are 9,11,1,11.
// For best photo quality, especially on the largest block sizes, the RGB weights should be set to roughly 9,11,1, and alpha set to ~G, so 11.