Scarfski/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-10-25 02:10:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed render bind hash collision reusing another draw's bindings. (#4015)

Browse Source
This commit is contained in:
Branimir Karadžić
2026-10-02 18:11:49 -07:00
committed by GitHub
parent 500f916540
commit abf165d8a7
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/bgfx_p.h
View File

@@ -4397,21 +4397,19 @@ namespace bgfx
const uint32_t hash = hashBindings(m_bind.m_bind, m_bindOccupied);
BindHashMap::const_iterator it = m_bindHashMap.find(hash);
if (it != m_bindHashMap.end() )
if (it != m_bindHashMap.end()
&& bindingsEqual(m_frame->m_renderBind[it->second].m_bind, m_bind.m_bind) )
{
const uint32_t idx = it->second;
BX_ASSERT(bindingsEqual(m_frame->m_renderBind[idx].m_bind, m_bind.m_bind)
, "RenderBind hash collision (hash 0x%08x)."
, hash
);
return idx;
return it->second;
}
const uint32_t idx = bx::atomicFetchAndAddsat<uint32_t>(&m_frame->m_numRenderBinds, 1, m_frame->m_maxDrawCalls);
m_frame->m_renderBind[idx] = m_bind;
m_bindHashMap.insert(stl::make_pair(hash, idx) );
if (it == m_bindHashMap.end() )
{
m_bindHashMap.insert(stl::make_pair(hash, idx) );
}
return idx;
}