Scarfski/bgfx
1
0
Fork 0
mirror of https://github.com/bkaradzic/bgfx.git synced 2026-09-09 12:08:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Metal: Fixed depth/stencil store action on the main swap chain when using MSAA. (#3683)

Browse Source
This commit is contained in:
Branimir Karadžić
2026-04-22 16:34:12 -07:00
committed by GitHub
parent 50bf41b224
commit d6458ee253
1 changed files with 18 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/renderer_mtl.cpp
View File

@@ -4751,17 +4751,15 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
desc->setLoadAction(MTL::LoadActionLoad);
}
if (NULL != m_capture
&& !isValid(fbh)
&& m_hasStoreActionStoreAndMultisampleResolve)
{
desc->setStoreAction(desc->texture()->sampleCount() > 1 ? MTL::StoreActionStoreAndMultisampleResolve : MTL::StoreActionStore);
const MTL::StoreAction multisampleStoreAction = m_hasStoreActionStoreAndMultisampleResolve
? MTL::StoreActionStoreAndMultisampleResolve
: MTL::StoreActionMultisampleResolve
;
}
else
{
desc->setStoreAction(desc->texture()->sampleCount() > 1 ? MTL::StoreActionMultisampleResolve : MTL::StoreActionStore);
}
desc->setStoreAction(desc->texture()->sampleCount() > 1
? multisampleStoreAction
: MTL::StoreActionStore
);
}
}
@@ -4774,10 +4772,7 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
? MTL::LoadActionClear
: MTL::LoadActionLoad)
;
depthAttachment->setStoreAction(NULL != m_mainFrameBuffer.m_swapChain && NULL != m_mainFrameBuffer.m_swapChain->m_backBufferColorMsaa
? MTL::StoreActionDontCare
: MTL::StoreActionStore)
;
depthAttachment->setStoreAction(MTL::StoreActionStore);
}
MTL::RenderPassStencilAttachmentDescriptor* stencilAttachment = renderPassDescriptor->stencilAttachment();
@@ -4789,10 +4784,7 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
? MTL::LoadActionClear
: MTL::LoadActionLoad)
;
stencilAttachment->setStoreAction(NULL != m_mainFrameBuffer.m_swapChain && NULL != m_mainFrameBuffer.m_swapChain->m_backBufferColorMsaa
? MTL::StoreActionDontCare
: MTL::StoreActionStore)
;
stencilAttachment->setStoreAction(MTL::StoreActionStore);
}
}
else
@@ -4804,17 +4796,15 @@ static_assert(BX_COUNTOF(s_accessNames) == Access::Count, "Invalid s_accessNames
{
desc->setLoadAction(MTL::LoadActionLoad);
if (NULL != m_capture
&& !isValid(fbh)
&& m_hasStoreActionStoreAndMultisampleResolve)
{
desc->setStoreAction(desc->texture()->sampleCount() > 1 ? MTL::StoreActionStoreAndMultisampleResolve : MTL::StoreActionStore);
const MTL::StoreAction multisampleStoreAction = m_hasStoreActionStoreAndMultisampleResolve
? MTL::StoreActionStoreAndMultisampleResolve
: MTL::StoreActionMultisampleResolve
;
}
else
{
desc->setStoreAction(desc->texture()->sampleCount() > 1 ? MTL::StoreActionMultisampleResolve : MTL::StoreActionStore);
}
desc->setStoreAction(desc->texture()->sampleCount() > 1
? multisampleStoreAction
: MTL::StoreActionStore
);
}
}