Scarfski/entt
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

meta: avoid copying meta_custom_node as not needed (perf)

Browse Source
This commit is contained in:
skypjack
2025-09-11 17:54:10 +02:00
parent 3c75f7e2fd
commit 5497291c29
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/entt/meta/meta.hpp
View File

@@ -783,8 +783,8 @@ struct meta_custom {
* @brief Basic constructor for meta objects.
* @param curr The underlying node with which to construct the instance.
*/
meta_custom(internal::meta_custom_node curr) noexcept
: node{std::move(curr)} {}
meta_custom(const internal::meta_custom_node &curr) noexcept
: node{&curr} {}
/**
* @brief Generic conversion operator.
@@ -792,7 +792,7 @@ struct meta_custom {
*/
template<typename Type>
[[nodiscard]] operator Type *() const noexcept {
return (type_id<Type>().hash() == node.type) ? static_cast<Type *>(node.value.get()) : nullptr;
return ((node != nullptr) && (type_id<Type>().hash() == node->type)) ? static_cast<Type *>(node->value.get()) : nullptr;
}
/**
@@ -801,12 +801,12 @@ struct meta_custom {
*/
template<typename Type>
[[nodiscard]] operator Type &() const noexcept {
ENTT_ASSERT(type_id<Type>().hash() == node.type, "Invalid type");
return *static_cast<Type *>(node.value.get());
ENTT_ASSERT((node != nullptr) && (type_id<Type>().hash() == node->type), "Invalid type");
return *static_cast<Type *>(node->value.get());
}
private:
internal::meta_custom_node node{};
const internal::meta_custom_node *node{};
};
/*! @brief Opaque wrapper for data members. */