Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix SamplerGroup update issue (#5928)

Browse Source
This commit is contained in:
Ben Doherty
2022-08-16 10:46:35 -07:00
committed by Benjamin Doherty
parent b8c318d923
commit 11d17e1db3
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
filament/backend/src/SamplerGroup.cpp
View File

@@ -41,11 +41,12 @@ SamplerGroup& SamplerGroup::operator=(const SamplerGroup& rhs) noexcept {
void SamplerGroup::setSampler(size_t index, SamplerDescriptor sampler) noexcept {
if (UTILS_LIKELY(index < mBuffer.size())) {
if (mBuffer[index].s.u != sampler.s.u || mBuffer[index].t != sampler.t) {
// it's a big deal to mutate a sampler group, so we avoid doing it.
mBuffer[index] = sampler;
mDirty = true;
}
// We cannot compare two texture handles to determine if an update is needed. Texture
// handles are (quickly) recycled and therefore can't be used for that purpose. e.g. if a
// texture is destroyed, its handle could be reused quickly by another texture.
// TODO: find a way to avoid marking dirty if the texture does not change.
mBuffer[index] = sampler;
mDirty = true;
}
}