Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

WebGL fix for "createContext is not a function".

Browse Source 
One of the recent releases of emsdk moved its GL-related utility methods
into an object called GL, previously it exposed them directly.

This change also makes it so that we create the WebGL 2.0 context
and register it with emscripten, rather than the other way around.

Note that our CI does "emsdk activate latest", not sure when this broke
exactly.
This commit is contained in:
Philip Rideout
2019-03-28 11:23:05 -07:00
parent feb7d968b6
commit 1fc8e8dbeb
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/filament-js/extensions.js
+8 -4
View File
@@ -43,12 +43,16 @@ Filament.loadClassExtensions = function() {
alpha: false
};
options = Object.assign(defaults, options);
Filament.createContext(canvas, true, true, options);
// Create the WebGL 2.0 context and register it with emscripten.
const ctx = canvas.getContext("webgl2", options);
const handle = GL.registerContext(ctx, options);
GL.makeContextCurrent(handle);
// Enable all desired extensions by calling getExtension on each one.
Filament.ctx.getExtension('WEBGL_compressed_texture_s3tc');
Filament.ctx.getExtension('WEBGL_compressed_texture_astc');
Filament.ctx.getExtension('WEBGL_compressed_texture_etc');
ctx.getExtension('WEBGL_compressed_texture_s3tc');
ctx.getExtension('WEBGL_compressed_texture_astc');
ctx.getExtension('WEBGL_compressed_texture_etc');
return Filament.Engine._create();
};