Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perfcounters are now disabled by default

Browse Source 
To enable some basic profiling of the gl thread using performance
counters, the "filament.perfcounters" property must be set to 1
(before the Filament Engine is created):

    adb shell setprop filament.perfcounters 1

This is so that filament doesn't interfere with simpleperf by default.
This commit is contained in:
Pixelflinger
2020-05-27 15:04:35 -07:00
committed by Mathias Agopian
parent 1e65b4d8af
commit 62d0f9f033
2 changed files with 25 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
filament/backend/include/private/backend/CommandStream.h
View File

@@ -297,6 +297,8 @@ private:
std::thread::id mThreadId;
#endif
bool mUsePerformanceCounter = false;
inline void* allocateCommand(size_t size) {
assert(mThreadId == std::this_thread::get_id());
return mCurrentBuffer->allocate(size);

35
filament/backend/src/CommandStream.cpp
View File

@@ -23,6 +23,10 @@
#include <functional>
#ifdef ANDROID
#include <sys/system_properties.h>
#endif
using namespace utils;
namespace filament {
@@ -60,6 +64,11 @@ CommandStream::CommandStream(Driver& driver, CircularBuffer& buffer) noexcept
, mThreadId(std::this_thread::get_id())
#endif
{
#ifdef ANDROID
char property[PROP_VALUE_MAX];
__system_property_get("filament.perfcounters", property);
mUsePerformanceCounter = bool(atoi(property));
#endif
}
void CommandStream::execute(void* buffer) {
@@ -68,9 +77,11 @@ void CommandStream::execute(void* buffer) {
Profiler profiler;
if (SYSTRACE_TAG) {
// we want to remove all this when tracing is completely disabled
profiler.resetEvents(Profiler::EV_CPU_CYCLES | Profiler::EV_L1D_RATES | Profiler::EV_BPU_RATES);
profiler.start();
if (UTILS_UNLIKELY(mUsePerformanceCounter)) {
// we want to remove all this when tracing is completely disabled
profiler.resetEvents(Profiler::EV_CPU_CYCLES | Profiler::EV_BPU_MISSES);
profiler.start();
}
}
mDriver->execute([this, buffer]() {
@@ -82,16 +93,16 @@ void CommandStream::execute(void* buffer) {
});
if (SYSTRACE_TAG) {
// we want to remove all this when tracing is completely disabled
UTILS_UNUSED Profiler::Counters counters = profiler.readCounters();
SYSTRACE_VALUE32("GLThread (I)", counters.getInstructions());
SYSTRACE_VALUE32("GLThread (C)", counters.getCpuCycles());
SYSTRACE_VALUE32("GLThread (CPI x10)", counters.getCPI() * 10);
SYSTRACE_VALUE32("GLThread (L1D HR%)", counters.getL1DHitRate() * 100);
if (profiler.hasBranchRates()) {
SYSTRACE_VALUE32("GLThread (BHR%)", counters.getBranchHitRate() * 100);
} else {
if (UTILS_UNLIKELY(mUsePerformanceCounter)) {
// we want to remove all this when tracing is completely disabled
profiler.stop();
UTILS_UNUSED Profiler::Counters counters = profiler.readCounters();
SYSTRACE_VALUE32("GLThread (I)", counters.getInstructions());
SYSTRACE_VALUE32("GLThread (C)", counters.getCpuCycles());
SYSTRACE_VALUE32("GLThread (CPI x10)", counters.getCPI() * 10);
SYSTRACE_VALUE32("GLThread (BPU miss)", counters.getBranchMisses());
SYSTRACE_VALUE32("GLThread (I / BPU miss)",
counters.getInstructions() / counters.getBranchMisses());
}
}
}