Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FilamentApp: fix projection matrix

Browse Source 
For some reason we were not setting the aspect-ratio to 1 and scaling 
the clip-space instead. This could lead to lighting and clipping
issues.
This commit is contained in:
Mathias Agopian
2025-08-21 20:21:56 -07:00
committed by Mathias Agopian
parent 0471c5de2f
commit 9aaa1bf413
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
libs/filamentapp/src/FilamentApp.cpp
View File

@@ -979,25 +979,22 @@ void FilamentApp::Window::configureCamerasForWindow() {
double near = mFilamentApp->mCameraNear;
double far = mFilamentApp->mCameraFar;
if (mMainView->getView()->getStereoscopicOptions().enabled) {
mat4 projections[4];
projections[0] = Camera::projection(mFilamentApp->mCameraFocalLength, 1.0, near, far);
projections[1] = projections[0];
// simulate foveated rendering
projections[2] = Camera::projection(mFilamentApp->mCameraFocalLength * 2.0, 1.0, near, far);
projections[3] = projections[2];
mMainCamera->setCustomEyeProjection(projections, 4, projections[0], near, far);
} else {
mMainCamera->setLensProjection(mFilamentApp->mCameraFocalLength, 1.0, near, far);
}
mDebugCamera->setProjection(45.0, double(mainWidth) / height, 0.0625, 4096, Camera::Fov::VERTICAL);
auto aspectRatio = double(mainWidth) / height;
if (mMainView->getView()->getStereoscopicOptions().enabled) {
const int ec = mConfig.stereoscopicEyeCount;
aspectRatio = double(mainWidth) / ec / height;
mat4 projections[4];
projections[0] = Camera::projection(mFilamentApp->mCameraFocalLength, aspectRatio, near, far);
projections[1] = projections[0];
// simulate foveated rendering
projections[2] = Camera::projection(mFilamentApp->mCameraFocalLength * 2.0, aspectRatio, near, far);
projections[3] = projections[2];
mMainCamera->setCustomEyeProjection(projections, 4, projections[0], near, far);
} else {
mMainCamera->setLensProjection(mFilamentApp->mCameraFocalLength, aspectRatio, near, far);
}
mMainCamera->setScaling({1.0 / aspectRatio, 1.0});
mDebugCamera->setProjection(45.0, aspectRatio, 0.0625, 4096, Camera::Fov::VERTICAL);
// We're in split view when there are more views than just the Main and UI views.
if (splitview) {