Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Web build, update Emscripten SDK to 3.1.60 (#8350)

Browse Source
This commit is contained in:
Ben Doherty
2025-01-15 11:42:39 -08:00
committed by GitHub
parent 026b985c07
commit ac0aea98c9
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
BUILDING.md
View File

@@ -356,7 +356,7 @@ same version that our continuous builds use.
```shell
cd <your chosen parent folder for the emscripten SDK>
curl -L https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.15.zip > emsdk.zip
curl -L https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.60.zip > emsdk.zip
unzip emsdk.zip ; mv emsdk-* emsdk ; cd emsdk
python ./emsdk.py install latest
python ./emsdk.py activate latest

2
build/web/ci-common.sh
View File

@@ -13,7 +13,7 @@ chmod +x ninja
export PATH="$PWD:$PATH"
# Install emscripten.
curl -L https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.15.zip > emsdk.zip
curl -L https://github.com/emscripten-core/emsdk/archive/refs/tags/3.1.60.zip > emsdk.zip
unzip emsdk.zip ; mv emsdk-* emsdk ; cd emsdk
./emsdk install latest
./emsdk activate latest

2
web/filament-js/jsbindings.cpp
View File

@@ -1050,7 +1050,7 @@ class_<RenderableManager>("RenderableManager")
.class_function("Builder", (RenderableBuilder (*)(int)) [] (int n) {
return RenderableBuilder(n);
})
}, return_value_policy::take_ownership())
.function("destroy", &RenderableManager::destroy)
.function("setAxisAlignedBoundingBox", &RenderableManager::setAxisAlignedBoundingBox)