Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a couple depthClamp issues on metal

Browse Source 
- depthClamp is only supported from iOS 11.0
- reset the depthClamp state at the beginning of the renderpass


BUGS=[379729888]
This commit is contained in:
Mathias Agopian
2024-12-02 23:37:19 -08:00
committed by Mathias Agopian
parent 8088db6282
commit b48a1556b6
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
filament/backend/src/metal/MetalContext.h
View File

@@ -135,6 +135,7 @@ struct MetalContext {
bool supportsTextureSwizzling = false;
bool supportsAutoDepthResolve = false;
bool supportsMemorylessRenderTargets = false;
bool supportsDepthClamp = false;
uint8_t maxColorRenderTargets = 4;
struct {
uint8_t common;

18
filament/backend/src/metal/MetalDriver.mm
View File

@@ -151,6 +151,11 @@ MetalDriver::MetalDriver(
mContext->highestSupportedGpuFamily.mac >= 2; // newer macOS GPUs
}
mContext->supportsDepthClamp = false;
if (@available(macOS 10.11, iOS 11.0, *)) {
mContext->supportsDepthClamp = true;
}
// In order to support resolve store action on depth attachment, the GPU needs to support it.
// Note that support for depth resolve implies support for stencil resolve using .sample0 resolve filter.
// (Other resolve filters are supported starting .apple5 and .mac2 families).
@@ -1063,7 +1068,7 @@ bool MetalDriver::isProtectedTexturesSupported() {
}
bool MetalDriver::isDepthClampSupported() {
return true;
return mContext->supportsDepthClamp;
}
bool MetalDriver::isWorkaroundNeeded(Workaround workaround) {
@@ -1258,6 +1263,7 @@ void MetalDriver::beginRenderPass(Handle<HwRenderTarget> rth,
mContext->cullModeState.invalidate();
mContext->windingState.invalidate();
mContext->scissorRectState.invalidate();
mContext->depthClampState.invalidate();
mContext->currentPolygonOffset = {0.0f, 0.0f};
mContext->finalizedDescriptorSets.clear();
@@ -1729,10 +1735,12 @@ void MetalDriver::bindPipeline(PipelineState const& ps) {
}
// depth clip mode
MTLDepthClipMode depthClipMode = rs.depthClamp ? MTLDepthClipModeClamp : MTLDepthClipModeClip;
mContext->depthClampState.updateState(depthClipMode);
if (mContext->depthClampState.stateChanged()) {
[mContext->currentRenderPassEncoder setDepthClipMode:depthClipMode];
if (mContext->supportsDepthClamp) {
MTLDepthClipMode depthClipMode = rs.depthClamp ? MTLDepthClipModeClamp : MTLDepthClipModeClip;
mContext->depthClampState.updateState(depthClipMode);
if (mContext->depthClampState.stateChanged()) {
[mContext->currentRenderPassEncoder setDepthClipMode:depthClipMode];
}
}
// Set the depth-stencil state, if a state change is needed.