Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Vulkan: remove layout checks from SwapChain.

Browse Source 
These asserts will come back in the next Filament release, which has
much cleaner layout tracking.
This commit is contained in:
Philip Rideout
2022-02-23 13:48:10 -08:00
parent 73f0d58e10
commit babbfa1394
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
filament/backend/src/vulkan/VulkanSwapChain.cpp
View File

@@ -29,14 +29,6 @@ namespace backend {
bool VulkanSwapChain::acquire() {
if (headlessQueue) {
currentSwapIndex = (currentSwapIndex + 1) % mColor.size();
// Next we perform a quick sanity check on layout for headless swap chains. It's easier to
// catch errors here than with validation. If this is the first time a particular image has
// been acquired, it should be in an UNDEFINED state. If this is not the first time, then it
// should be in the normal layout that we use for color attachments.
assert_invariant(this->getColorAttachment().layout == VK_IMAGE_LAYOUT_UNDEFINED ||
this->getColorAttachment().layout == getDefaultImageLayout(TextureUsage::COLOR_ATTACHMENT));
return true;
}
@@ -52,11 +44,6 @@ bool VulkanSwapChain::acquire() {
suboptimal = true;
}
// Next perform a quick sanity check on the image layout. Similar to attachable textures, we
// immediately transition the swap chain image layout during the first render pass of the frame.
assert_invariant(this->getColorAttachment().layout == VK_IMAGE_LAYOUT_UNDEFINED ||
this->getColorAttachment().layout == VK_IMAGE_LAYOUT_PRESENT_SRC_KHR);
// To ensure that the next command buffer submission does not write into the image before
// it has been acquired, push the image available semaphore into the command buffer manager.
mContext.commands->injectDependency(imageAvailable);