Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix refraction + MSAA + TAA (depth resolve)

Browse Source 
the depth buffer wasn't resolved in this case. We fix this by always
creating a depth buffer resolve pass -- which is a lot more robust.
this pass automatically culled if the depth is not used (i.e. TAA or 
DoF are off). The pass is a no-op if resolving is not needed.
This commit is contained in:
Pixelflinger
2020-08-29 01:24:28 -07:00
committed by Mathias Agopian
parent 84f0e97c78
commit bcd8ce3c93
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
filament/src/Renderer.cpp
View File

@@ -442,6 +442,13 @@ void FRenderer::renderJob(ArenaScope& arena, FView& view) {
refractionPass(fg, config, colorGradingConfigForColor, pass, view);
FrameGraphId<FrameGraphTexture> input = colorPassOutput;
// resolve depth -- which might be needed because of TAA. This pass will be culled
// if the depth is not use below.
auto& blackboard = fg.getBlackboard();
auto depth = blackboard.get<FrameGraphTexture>("depth");
depth = ppm.resolve(fg, "Resolved Depth Buffer", depth);
blackboard.put("depth", depth);
// TAA for color pass
if (taaOptions.enabled) {
input = ppm.taa(fg, input, view.getFrameHistory(), taaOptions, colorGradingConfig);
@@ -458,14 +465,6 @@ void FRenderer::renderJob(ArenaScope& arena, FView& view) {
if (hasPostProcess) {
if (dofOptions.enabled) {
// dof needs access to the depth buffer, when MSAA is enabled, it might need
// to be resolved.
auto& blackboard = fg.getBlackboard();
auto depth = blackboard.get<FrameGraphTexture>("depth");
depth = ppm.resolve(fg, "Resolved Depth Buffer", depth);
blackboard.put("depth", depth);
input = ppm.dof(fg, input, dofOptions, needsAlphaChannel, cameraInfo);
}
if (colorGrading) {