Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix places where generateMipmaps is called without proper usage (#9054)

Browse Source
This commit is contained in:
Powei Feng
2025-08-07 15:24:40 -07:00
committed by GitHub
parent db14efc151
commit c8ab2f335e
6 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/filamentapp/src/MeshAssimp.cpp
View File

@@ -204,6 +204,7 @@ Texture* MeshAssimp::createOneByOneTexture(uint32_t pixel) {
.height(uint32_t(1))
.levels(0xff)
.format(Texture::InternalFormat::RGBA8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(mEngine);
Texture::PixelBufferDescriptor defaultNormalBuffer(textureData,

1
samples/image_viewer.cpp
View File

@@ -245,6 +245,7 @@ static void loadImage(App& app, Engine* engine, const Path& filename) {
.format(channels == 3 ?
Texture::InternalFormat::RGB16F : Texture::InternalFormat::RGBA16F)
.sampler(Texture::Sampler::SAMPLER_2D)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor::Callback freeCallback = [](void* buf, size_t, void* data) {

1
samples/sample_cloth.cpp
View File

@@ -169,6 +169,7 @@ Texture* loadMap(Engine* engine, const char* name, bool sRGB = true) {
.height(uint32_t(h))
.levels(0xff)
.format(sRGB ? Texture::InternalFormat::SRGB8 : Texture::InternalFormat::RGB8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor buffer(data, size_t(w * h * 3),
Texture::Format::RGB, Texture::Type::UBYTE,

1
samples/sample_full_pbr.cpp
View File

@@ -220,6 +220,7 @@ bool loadTexture(Engine* engine, const std::string& filePath, Texture** map, boo
.height(uint32_t(h))
.levels(0xff)
.format(sRGB ? Texture::InternalFormat::SRGB8 : Texture::InternalFormat::RGB8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor buffer(data, size_t(w * h * 3),
Texture::Format::RGB, Texture::Type::UBYTE,

2
samples/sample_normal_map.cpp
View File

@@ -193,6 +193,7 @@ void loadNormalMap(Engine* engine, Texture** normalMap, const std::string& path)
.height(uint32_t(h))
.levels(0xff)
.format(Texture::InternalFormat::RGB8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor buffer(data, size_t(w * h * 3),
Texture::Format::RGB, Texture::Type::UBYTE,
@@ -220,6 +221,7 @@ void loadBaseColorMap(Engine* engine) {
.height(uint32_t(h))
.levels(0xff)
.format(Texture::InternalFormat::SRGB8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor buffer(data, size_t(w * h * 3),
Texture::Format::RGB, Texture::Type::UBYTE,

1
samples/suzanne.cpp
View File

@@ -120,6 +120,7 @@ static Texture* loadNormalMap(Engine* engine, const uint8_t* normals, size_t nby
.height(uint32_t(h))
.levels(0xff)
.format(Texture::InternalFormat::RGB8)
.usage(Texture::Usage::DEFAULT | Texture::Usage::GEN_MIPMAPPABLE)
.build(*engine);
Texture::PixelBufferDescriptor buffer(data, size_t(w * h * 3),
Texture::Format::RGB, Texture::Type::UBYTE,