Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add precondition check for skinning offset bounds

Browse Source
This commit is contained in:
Mathias Agopian
2026-03-30 22:14:09 -07:00
committed by Mathias Agopian
parent 67e4561f2e
commit f1abc9a4d2
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
filament/src/components/RenderableManager.cpp
View File

@@ -55,6 +55,7 @@
#include <math/vec4.h>
#include <algorithm>
#include <limits>
#include <memory>
#include <unordered_map>
#include <utility>
@@ -477,6 +478,9 @@ RenderableManager::Builder::Result RenderableManager::Builder::build(Engine& eng
FILAMENT_CHECK_PRECONDITION(mImpl->mSkinningBoneCount <= CONFIG_MAX_BONE_COUNT)
<< "bone count > " << CONFIG_MAX_BONE_COUNT;
FILAMENT_CHECK_PRECONDITION(mImpl->mSkinningBufferOffset <= std::numeric_limits<uint16_t>::max())
<< "skinning buffer offset > " << std::numeric_limits<uint16_t>::max();
FILAMENT_CHECK_PRECONDITION(
mImpl->mInstanceCount <= CONFIG_MAX_INSTANCES || !mImpl->mInstanceBuffer)
<< "instance count is " << mImpl->mInstanceCount
@@ -928,6 +932,9 @@ void FRenderableManager::setBones(Instance const ci,
FILAMENT_CHECK_PRECONDITION(!bones.skinningBufferMode)
<< "Disable skinning buffer mode to use this API";
FILAMENT_CHECK_PRECONDITION(offset <= bones.count)
<< "bone offset is out of bounds (" << offset << " > " << bones.count << ")";
assert_invariant(bones.handle && offset + boneCount <= bones.count);
if (bones.handle) {
boneCount = std::min(boneCount, bones.count - offset);
@@ -944,6 +951,9 @@ void FRenderableManager::setBones(Instance const ci,
FILAMENT_CHECK_PRECONDITION(!bones.skinningBufferMode)
<< "Disable skinning buffer mode to use this API";
FILAMENT_CHECK_PRECONDITION(offset <= bones.count)
<< "bone offset is out of bounds (" << offset << " > " << bones.count << ")";
assert_invariant(bones.handle && offset + boneCount <= bones.count);
if (bones.handle) {
boneCount = std::min(boneCount, bones.count - offset);