filament

Scarfski/filament

Fork 0

Commit Graph

Author	SHA1	Message	Date
Philip Rideout	f4806461ee	Fix JavaScript leaks with BufferDescriptor. Fixes #429	2018-11-08 16:17:29 -08:00
Philip Rideout	207d4ea4c1	Fix JS API leaks by auto-deleting builders, etc. While this solves the builder leak, it does not solve the tiny leak incurred every time you call `getInstance` on a component manager without calling embind's `delete` method afterwards. Since there's no way to auto-delete component instances, this CL fixes up our sample code and docstrings. Fixes #429	2018-11-08 16:17:29 -08:00
Philip Rideout	5fb0696fb7	Resurrect the JS memory leak test (#429 )	2018-11-08 11:16:41 -08:00

Author

SHA1

Message

Date

Philip Rideout

f4806461ee

Fix JavaScript leaks with BufferDescriptor.

Fixes #429

2018-11-08 16:17:29 -08:00

Philip Rideout

207d4ea4c1

Fix JS API leaks by auto-deleting builders, etc.

While this solves the builder leak, it does not solve the tiny leak
incurred every time you call `getInstance` on a component manager
without calling embind's `delete` method afterwards. Since there's no
way to auto-delete component instances, this CL fixes up our sample
code and docstrings.

Fixes #429

2018-11-08 16:17:29 -08:00

Philip Rideout

5fb0696fb7

Resurrect the JS memory leak test (#429 )

2018-11-08 11:16:41 -08:00

3 Commits