Commit Graph

6836 Commits

Author SHA1 Message Date
Doris Wu
78487f4836 [fgviewer] Collapse subresources by default in web view (#8517)
* Collapse subresources by default

* Fix typo
2025-03-12 14:58:54 +00:00
bridgewaterrobbie
25e9802fd5 Add validate wgsl pipleine test 2025-03-11 17:40:21 -04:00
bridgewaterrobbie
dacd03ce42 Adjust running the test to fail on 0 tests. This is to ensure we don't pass the test due to the webgpu build failing or similar 2025-03-11 17:40:21 -04:00
bridgewaterrobbie
c9cfc63df0 Add tests to convert sample shaders with Tint to WGSL 2025-03-11 17:40:21 -04:00
Juan David Caldas
9c69cb8484 Enable WebGPU option for matc and add WGSL options for shader generation 2025-03-11 17:40:21 -04:00
Matthew Hoffman
8ea4cb50d2 Add helpers for backend tests. (#8505)
Both for cleaning up graphics resources at the end of a test and for starting/stopping render loops.

BUGS=[402472882]
2025-03-11 14:25:32 -05:00
Mathias Agopian
4f8080ead2 Fix material instance check log when destroying material
When the feature flags assert_destroy_material_before_material_instance
is disabled, we emit a log instead of an assert. Unfortunately this log
would be emitted even when all material instances were destroyed.
2025-03-11 11:09:11 -07:00
rafadevai
34ebe45e2a vk: External Texture implementation for Vulkan (#8488)
Add support for the new createTextureExternalImage2R
API instead of createTextureExternalImageR.

Add the support to import AHardwareBuffer objects
into Vulkan in Android.
2025-03-11 06:01:28 +00:00
Sungun Park
bb3e3df2f4 Fix release notes 2025-03-10 22:35:35 +00:00
Sungun Park
0bcb45613e Release Filament 1.58.0 2025-03-10 22:11:59 +00:00
Powei Feng
0a0d4ed23a Update HandleAllocator in test (#8508) 2025-03-10 12:49:58 -07:00
Ajmal Kunnummal
b9a39bc066 Add a way to pass a transform matrix along with Stream::setAcquiredImage (#8496)
BUGS=[399959254]
---------

Co-authored-by: Syed Idris Shah <idrisshah@google.com>
Co-authored-by: Haneul Kim <haneulk730@gmail.com>
Co-authored-by: Powei Feng <powei@google.com>
Co-authored-by: Doris Wu <doriswu@google.com>
Co-authored-by: Mathias Agopian <mathias@google.com>
2025-03-10 09:58:58 -07:00
Powei Feng
e825f43935 matdbg: indicate shader model (#8504)
Shader model (desktop or mobile) wasn't really accounted for
in the UI. This means that we will get shaders that look like
duplicates (same variant). In this work, we pass the current
shader model from engine into the frontend and filter out
variants of a different shader model.

Moreover, for matinfo, we use a specific dbg shader model (matinfo)
to indicate it is in that mode. We add UI in matinfo to show the
shadermodel.

So UI updates as well.
2025-03-07 23:54:22 +00:00
alizahlalani
ee68872a47 Add ahb mapping util functions to map ahb usage and format to TextureUsage and TextureFormat (#8491) 2025-03-07 22:28:56 +00:00
Konstantin Sakhin
2f4e48b6b9 Texture: prevent SIGILL in sampler validator. (#8468)
Co-authored-by: Romain Guy <romainguy@curious-creature.com>
2025-03-07 12:11:04 -08:00
Powei Feng
5091b3112d matdbg: fix variant issue for surface materials (#8503)
- The set of active variants were not set correctly for surface
   materials since the frag/vert pairs could have different
   variant.
 - Fix the default selection logic in the UI
 - Random clean-ups

FIXES=328699979
2025-03-07 17:46:04 +00:00
Ajmal Kunnummal
7199961248 Update the associated uniforms every frame for materials with attached Streams (#8493)
BUGS=[399959254]
2025-03-07 01:05:44 +00:00
bridgewaterrobbie
d0a00803c1 Restore workaround for CONFIG_MAX_INSTANCES and CONFIG_FROXEL_BUFFER_HEIGHT not being a spec constant, because WGSL does not support that being an array length (#8479) 2025-03-07 00:28:36 +00:00
Sungun Park
0e3ef4bd63 Disable picking for multiview rendering (#8502)
Picking is not designed to work with multiview rendering. Disable it
when multiview is enabled.
2025-03-07 00:05:36 +00:00
Ben Doherty
c24535a6e4 Update permissions for GitHub release job 2025-03-06 15:00:48 -08:00
bridgewaterrobbie
74b09c708a Enable TINT_BUILD_SPV_READER on host platform webgpu builds 2025-03-06 17:12:03 -05:00
bridgewaterrobbie
80e0dbaa8a When preprocess fails, return false from process 2025-03-06 17:12:03 -05:00
bridgewaterrobbie
31e966f63f Add initial Tint support for shader transpile
Early version that will allow errors to be ignored currently, outputting what we can into filamat results.
2025-03-06 17:12:03 -05:00
Ajmal Kunnummal
02223dcaab Add a way to specify an additional uniform name along with a sampler param for the associated transform matrix (#8490)
BUGS=[399959254]
2025-03-06 18:42:24 +00:00
Ajmal Kunnummal
47112f136e Add a way to query the transform matrix of a surface texture from the driver (#8489)
* Add a way to query the transform matrix of a surface texture from the driver

BUGS=[399959254]
2025-03-06 10:23:06 -08:00
HanYunChenLuo
30bb4ad6eb fix SourceFormatter.h missing header file (#8498)
missing <string>
2025-03-06 09:22:29 -08:00
Doris Wu
d9e30460dc Enable fgviewer for android remote debugging (#8483)
* Enable fgviewer for the users

* Fix incorrect position

* Update

* Support remote debug server

* Enable fgviewer on android

* Link and include fgviewer_resources

* Adjust js to show untitled view
2025-03-06 05:36:41 +00:00
Doris Wu
075743ef59 Aggregate the subresource usage when collapsed (#8492) 2025-03-06 02:08:55 +00:00
Powei Feng
bd3a0d5377 Release Filament 1.57.2 2025-03-05 14:37:22 -08:00
Haneul Kim
4ede119c6d vk: Fix cleanup logic in VulkanStagePool::terminate (#8484)
Updated the `terminate` function to correct resource cleanup. Changed `mUsedStages` to `mUsedImages` and `mFreeStages` to `mFreeImages` to ensure proper memory management during termination.
2025-03-05 07:03:44 +00:00
Syed Idris Shah
14e3ae51c1 Update android build to use webgpu 2025-03-04 22:09:19 -05:00
Syed Idris Shah
86e71f37ae Add WebGPU stub backend code.
Introduce Enums to support WebGPU.
Start to use header files from dawn.
2025-03-04 22:09:19 -05:00
Syed Idris Shah
eb1e2dbe1b Compile dawn with filament codebase
Introduce FILAMENT_SUPPORTS_WEBGPU flag to be used for webgpu support.
Add -W option to  build.sh for webgpu support compilation from build script.

Thanks Andy Hovingh for helping out with this implementation
2025-03-04 22:09:19 -05:00
Syed Idris Shah
160fe34bc8 Add tnt folder for compilation with filament
Replace cmakelist content with few set and includes
Add the patch file to convert dawn shared to static lib

Thanks Robbie Bridgewater for helping out with this implementation
2025-03-04 22:09:19 -05:00
Syed Idris Shah
bd289054e4 build.sh: Cleanup leftover option j from build.sh 2025-03-04 22:09:19 -05:00
Doris Wu
44883fe5fc Add README.md (#8485) 2025-03-05 00:55:06 +00:00
Ben Doherty
0b5f95b28e Fix: Metal crashing when a render pass is abandoned (#8481) 2025-03-04 10:14:11 -08:00
Doris Wu
11b0327956 Enable fgviewer (#8453)
* Enable fgviewer for the users

* Fix incorrect position

* Update

* Remove IS_HOST_PLATFORM

* Set fgviewer to off by default on host platform
2025-03-04 05:52:24 +00:00
Syed Idris Shah
22b01ab852 Add dawn to third_party from https://github.com/google/dawn
Current copy is cloned using hash: 51694fd33cdaaec5bdd7ab3dc4f488f5818fd870

.git and .gitignore have been cleanup. tests,docs,webgpu-cts folders have been deleted.

For more details look at third_party/dawn/tnt/README.md file, which will be
pushed in subsequent patch.
2025-03-03 22:55:05 -05:00
Doris Wu
d0910b3fb6 Add resource details display to fgviewer web view (#8469)
* Add resource detail

* Add to_string for texture format

* Fix the type of currentResourceId

* Update

* Refactoring

* More refactoring

* Rename some properties

* Rename a function

* Address the comment

* Update the comment and remove if statement

* Fix indent
2025-03-01 02:54:54 +00:00
Mathias Agopian
95978f6fdc add a feature flag to control handle tags for heap handles
heap allocated handle tags are kept forever and we suspect this is
causing problems. the new feature flag "backend.disable_heap_handle_tags"
is enabled by default and controls if we store these tags at all or not.

BUGS=[397766275]
2025-02-28 16:30:59 -08:00
Amin Ya
cd4571700a fix: conditional cstdio include in vk_mem_alloc (#8265)
Based on 05973d8aeb/include/vk_mem_alloc.h (L2842)

Co-authored-by: Powei Feng <powei@google.com>
2025-02-27 23:26:31 +00:00
Amin Ya
ad2fdb4663 fix: const cast pair.first access for mg_websocket_write (#8264)
Co-authored-by: Powei Feng <powei@google.com>
2025-02-27 22:28:04 +00:00
Powei Feng
1b2ab09719 android: prevent leak of cubemap for IndirectLight/Skybox (#8470)
We break existing  API by returning both the IndirectLight and the
texture. Same thing with Skybox.

Fix one bug where the float array in getSphericalHarmonics wasn't
getting written out.

Fixes #6412
2025-02-27 20:14:22 +00:00
dependabot[bot]
2a2a6b7291 build(deps): bump the npm_and_yarn group across 1 directory with 3 updates (#8445)
Bumps the npm_and_yarn group with 2 updates in the /build/common/upload-release-assets directory: [@octokit/plugin-paginate-rest](https://github.com/octokit/plugin-paginate-rest.js) and [@octokit/rest](https://github.com/octokit/rest.js).


Updates `@octokit/plugin-paginate-rest` from 5.0.1 to 11.4.2
- [Release notes](https://github.com/octokit/plugin-paginate-rest.js/releases)
- [Commits](https://github.com/octokit/plugin-paginate-rest.js/compare/v5.0.1...v11.4.2)

Updates `@octokit/rest` from 19.0.5 to 21.1.0
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](https://github.com/octokit/rest.js/compare/v19.0.5...v21.1.0)

Updates `@octokit/request` from 6.2.2 to 9.2.1
- [Release notes](https://github.com/octokit/request.js/releases)
- [Commits](https://github.com/octokit/request.js/compare/v6.2.2...v9.2.1)

---
updated-dependencies:
- dependency-name: "@octokit/plugin-paginate-rest"
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: "@octokit/rest"
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: "@octokit/request"
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Powei Feng <powei@google.com>
2025-02-27 19:40:17 +00:00
bridgewaterrobbie
a19e8d357d Update glslang Dependencies to match Dawn requirements 2025-02-27 14:22:41 -05:00
bridgewaterrobbie
a937362ccc Update SPIR-V Dependencies to match Dawn requirements 2025-02-27 14:22:41 -05:00
bridgewaterrobbie
17091df8dc Update abseil version to match Dawn requirements 2025-02-27 14:22:41 -05:00
Powei Feng
ff1f2fcac6 vk: timer query refactor (#8459)
- Put QueryManager into its own .h/.cpp
 - Do not assert when endTime <= beginTime.  This could happen if
   they were set on different command buffers.  To be resolved
   later.
 - Better logic for iterating through a bitset.
2025-02-27 19:08:17 +00:00
Powei Feng
db30a9a50c viewer: add option to export TIFF in automation (#8472)
PPM does not store alpha channel, but TIFF does.  We add a method
to export RGBA to a TIFF file without compression.

We add the corresponding options to gltf_viewer and
AutomationEngine.

The default export format for both gltf_viewer and AutomationEngine
is now TIFF.
2025-02-27 18:54:37 +00:00