Commit Graph
8033 Commits
Author SHA1 Message Date
Serge Metral b85d52f727 External sampler bind index bug (#9664)
Patching a fix for the external sampler use case where the same sampler is bound to two different indices. As it stands, the code fails to differentiate between the two layouts.
2026-01-30 00:27:32 +00:00
Eliza Velasquez 53e6cd3126 engine: fix TAA compilation failure 2026-01-29 15:57:47 -08:00
Patrick Ribas 69ae8c491b Bump some uniforms to FL1 minimum (#9639) 2026-01-29 15:42:28 -08:00
haroonq c35ae6571f Swap logic of how the EGL display is initialized. (#9634)
1. Iterate over system displays using eglQueryDevicesEXT and try to initialize them.
2. If no display initialized, then try to initialize the DEFAULT display.

FIXES=[478925865]
2026-01-29 13:20:10 -08:00
Mathias Agopian 4c621b83e9 Fix possible buffer overflow in CommandStream (#9661)
Because of an improper boundary check caused a possible unsigned
integer overflow, it was possible to overrun the command stream
buffer in RenderPass::execute().

It would happen when the batch size was larger than the buffer
capacity (usually a few MB). 

FIXES=[474264976]
2026-01-29 09:42:23 -08:00
Patrick Ribas 4abf7cdaba Move eye matrix array to FL1 (#9656) 2026-01-29 08:54:14 -08:00
Filament Bot 9808aa5460 [automated] Updating /docs due to commit ef24164
Full commit hash is ef24164464

DOCS_ALLOW_DIRECT_EDITS
2026-01-29 07:35:58 +00:00
Patrick Ribas 5c15d56cf5 Remove PerRenderableData::reserved from FL0 (#9657) 2026-01-28 23:32:42 -08:00
Mathias Agopian ef24164464 Improve Moon/Earthshine, add Touch support (#9659)
- Fix Moon normal calculation in shader (was inverted).
- Implement physically based Earthshine (dynamic based on phase).
- Add Moon scattering to Water reflection.
- Fix Star occlusion (masked by Moon).
- Improved Stars
- Add mobile touch support (Orbit control) to Camera.

DOCS_FORCE
2026-01-28 23:32:06 -08:00
Powei Feng a1abfa30b8 github: use exsiting android native tgz in release (#9651)
However, the change also pulled in filament-android-release-linux.tgz,
which already contains the same content, into the release.

Here we just rename filament-android-release-linux.tgz to the
expected .tgz output file in the release build.

Fixes #9647
2026-01-28 21:29:42 +00:00
Powei Feng b5abcd9bc1 vk: use proper sync read bit after uploading ubo (#9644)
VK_ACCESS_UNIFORM_READ_BIT is for UBOs where as
VK_ACCESS_SHADER_READ_BIT is for other types of resources.
2026-01-28 19:17:06 +00:00
Powei Feng 8d34af2004 backend: add readTexture api and stubs (#9646) 2026-01-28 18:55:37 +00:00
Powei Feng db0524d59b imagediff: add image comparison library (#9640)
A library for verifying rendering results against golden images.

Key Features:
- Hierarchical checks (AND, OR, LEAF).
- Per-pixel masking.
- Global failure tolerance (`maxFailingPixelsFraction`).
- 8-bit `Bitmap` support.
- JSON configuration.
2026-01-28 10:35:36 -08:00
Powei Feng 6193f489a3 gltfio: prevent malformed gltf+draco mesh (#9638)
Fix is to move from assert() to FILAMENT_CHECK_PRECONDITION

FIXES=478028329
2026-01-28 18:14:06 +00:00
Filament Bot fb31759c27 [automated] Updating /docs due to commit 375e3a0
Full commit hash is 375e3a03ec

DOCS_ALLOW_DIRECT_EDITS
2026-01-28 09:29:12 +00:00
Mathias Agopian 375e3a03ec SkySim: add initial support for a moon (#9650)
- also update filament binaries

DOCS_FORCE
2026-01-28 01:25:03 -08:00
Filament Bot 11bf3a4493 [automated] Updating /docs due to commit 7c64fb9
Full commit hash is 7c64fb9cf3

DOCS_ALLOW_DIRECT_EDITS
2026-01-28 07:56:16 +00:00
Mathias Agopian 7c64fb9cf3 SimSky: Optimize URL state sharing and fix UI synchronization (#9649)
- **Key Minification**: Refactored serialization to use short keys
  (e.g., `p`, `c`, `w`) instead of verbose property names, reducing URL 
  size by ~50%.
- **State Optimization**: Removed redundant `sunDirection` from 
  serialized state.
- **Cleanup**: Removed backward compatibility for verbose keys 
- **Bug Fix**: Fixed a regression where UI sliders failed to update on 
  load by ensuring array properties (e.g., `sunHalo`) are mutated 
  in-place rather than replaced.

DOCS_FORCE
2026-01-27 23:52:49 -08:00
Filament Bot d3de9efc33 [automated] Updating /docs due to commit e9dcf2a
Full commit hash is e9dcf2a63a

DOCS_ALLOW_DIRECT_EDITS
2026-01-28 06:40:54 +00:00
Mathias Agopian e9dcf2a63a SimSky: Add URL state sharing and configuration persistence (#9648)
- **State Management**:
  - Refactored main.js to expose local UI parameter objects as class
    properties for serialization.
  - Implemented getURLState() to capture complete scene configuration 
    (Sky, Clouds, Water, Stars, Camera, Bloom).
  - Implemented applyURLState() to restore settings and synchronize 
    the UI.

- **URL Sharing**:
  - Added "Share Configuration" button to the UI.
  - Configuration is Base64-encoded into a `config` URL query parameter.
  - App now automatically parses and applies the `config` parameter 
    on startup, allowing for stateful deep linking.

DOCS_FORCE
2026-01-27 22:36:54 -08:00
Doris Wu 8008d21782 turn the checks into assert (#9642) 2026-01-28 05:59:14 +00:00
Powei Feng 852ecf048a filamat: remove unnecessary std::decay_t (#9643) 2026-01-27 18:02:42 -08:00
Filament Bot 3c91c74232 [automated] Updating /docs due to commit 8d20d7a
Full commit hash is 8d20d7abec

DOCS_ALLOW_DIRECT_EDITS
2026-01-27 22:57:02 +00:00
Benjamin Doherty 8d20d7abec Release Filament 1.69.0 2026-01-27 14:50:19 -08:00
Eliza 2f1266f7dd engine: add program cache (#9297)
* engine: add program cache

This is another chunky change.

The core of this change is to cache programs in MaterialCache according to a
"specialization" (ProgramSpecialization) which is defined as the program cache
ID (the same key used for the OpenGL binary blob cache), the variant, and the
set of spec constants.

As part of this change, a lot of the implementation details of shader
compilation were refactored from Material to MaterialDefinition. The resulting
flow is a lot cleaner and easier to reason about, since shader compilation is
now a pure function of the MaterialDefinition + ProgramSpecialization.

Since the global cache program lookups might take a bit of time to compute
hashes, etc, I left the set of cached programs in Material as well, which kind
of acts like an L1 cache. The effect is that prepareProgram() and getProgram()
should be no slower than HEAD, even with the more complex caching requirements.

I'm planning on writing a document about this (and all changes up until this
point), but I'm being asked to work on higher priority things and I wanted to
have this PR out for review in the meantime so it doesn't bitrot.

* engine: fix unit tests

* engine: fix spec constants intern pool memory leak

* engine: address program cache comments

* engine: address more program cache comments

* engine: matdbg support for program cache

* engine: reinstate descriptorLayout calls

* engine: address bitrot

* engine: add feature flag to disable program cache

* engine: use material CRC32 for program cache

The "cache ID" of a material is supposed to uniquely identify a shader program
and all its variants. This is true to a certain extent, but does not account for
the code generation that happens at runtime. Two materials may have "identical"
shader programs, but due to each material's differing unique metadata, the final
compiled programs may end up very different. Unfortunately, this means we cannot
rely on the "cache ID" alone to determine a shader program's reusability.

Ideally, we should hash this "cache ID" with the exact set of changes to each
shader program so that we could reuse programs across materials. Instead, as a
stopgap solution, use the material's CRC32 instead.

* engine: fix double-free in program cache

* engine: address comments

* engine: assert_invariant empty material cache
2026-01-27 13:09:42 -08:00
Benjamin Doherty 05be4b0acc Update filament-tools macOS classifier 2026-01-27 11:34:46 -08:00
Mathias Agopian 9d9c3d34f8 Fix a typo that corrupted the tags of descriptor sets and layouts (#9641)
- we were setting the tag of the descriptor set to its layout, so
  both tags were incorrect.

- added in debug build we now store the tag of the bound descriptor
  sets in the current bindings structure.
2026-01-27 10:44:04 -08:00
Powei Feng 491531c76b gltfio: fix possible overflow for meshopt decompression (#9637)
FIXES=478908360
2026-01-27 17:54:36 +00:00
Mathias Agopian bf4ea771be AtlasAllocator: Implement free() and upgrade to Buddy Allocator (#9635)
This change upgrades AtlasAllocator from a simple linear allocator 
(reset-only) to a full Buddy Allocator capable of both allocation and 
deallocation. This enables persistent shadow map management where 
individual shadow maps can be updated or resized without rebuilding the 
entire atlas every frame.

Key changes:
- Implemented AtlasAllocator::free():
	- Uses the existing QuadTree structure to track allocations.
	- Automatically coalesces empty sibling nodes back into larger 
      parent blocks (standard Buddy Allocator behavior).
	- Optimized to be allocation-free and recursion-free, using direct 
      array indexing.

- Added comprehensive unit tests

Updated documentation.

The QuadTreeArray implementation remains unchanged but is now fully 
utilized for bidirectional tree traversal (down for alloc, up for free).

This change will later allow us to cache shadow-maps.
The AtlasAlocator is currently disabled by a feature flag.
2026-01-27 09:21:20 -08:00
Doris Wu dd5882760b implement memory mapping for wgpu (#9632)
It is a zero effort implementation where it just calls `updateBufferObject` to update the data.
2026-01-27 03:05:46 +00:00
rafadevai 1707dda62a VK: Only bypass the staging buffer when is not in use (#9633)
In the cases where a frame takes more than the vsync
time, we start seeing some rendering artifacts because
we write to a buffer that is currently in flight.

Not 100% sure why the current approach fails but for
now, the staging buffer is bypassed only when the buffer
is not in use or referenced by any other resource.

FIXED=[445455050]
FIXED=[477305399]
2026-01-26 17:57:56 -08:00
Benjamin Doherty c4d3eded72 Bump MATERIAL_VERSION to 69 2026-01-26 14:00:12 -08:00
Powei Feng ca4b0650fa Re-commit "Generalize scene description for automated testing (#9627)"
Contains a fix to the default sunlight parameters that broke the
renderdiff tests.
2026-01-26 13:33:09 -08:00
Powei Feng 33d22b3146 Revert "[automated] Updating /docs due to commit 60b1951" and "Generalize scene description for automated testing (#9627)"
This reverts commit e2dd47bf42.
This reverts commit 60b1951f90.

renderdiff test breakage
2026-01-23 17:20:31 -08:00
Filament Bot e2dd47bf42 [automated] Updating /docs due to commit 60b1951
Full commit hash is 60b1951f90

DOCS_ALLOW_DIRECT_EDITS
2026-01-24 00:04:44 +00:00
Powei Feng 60b1951f90 Generalize scene description for automated testing (#9627)
- Extended Settings to include properties for Camera, Animation, Lights,
  and Render options.
- Moved camera options from Viewer options to Camera options
- Implemented generic JSON parsing for these new settings in Settings.cpp.
- Updated AutomationEngine to apply these settings, including dynamic
  creation of lights.
- Fixed a JSON parsing bug in AutomationSpec that failed on nested objects.
- Updated gltf_viewer to use the new settings and correctly initialize
  AutomationEngine context.
- Add test for new json changes
- Add README to libs/viewer
- Link libs/viewer/README.md to official doc
- Remove unused libs/viewer/schemas
- Updated remote web assets (because the viewer/settings json needs to
  match)
2026-01-24 00:02:06 +00:00
Filament Bot 6ce06b1b60 [automated] Updating /docs due to commit e21d4a5
Full commit hash is e21d4a5326

DOCS_ALLOW_DIRECT_EDITS
2026-01-23 09:10:02 +00:00
Mathias Agopian e21d4a5326 SimSky: Refine Stars, Water, and Heat Shimmer simulation (#9628)
- **Stars**:
  - Implemented procedural stars using hash-based noise.
  - Added UI controls for Star Density and Enable/Disable.
  - Tuned star brightness (reduced intensity) and refined twilight fade timing (visible during nautical twilight).
  - Improved compositing with aggressive cloud occlusion and non-linear fade.
  - Added star reflections to water, strictly masked to the horizon line.

- **Heat Shimmer**:
  - Fixed horizon artifacts by decoupling shimmer from atmospheric density (Mie scattering).
  - Implemented FBM-based view distortion for heat waves.
  - Added sun elevation fade (shimmer fades out as sun rises > 30°).

- **Water**:
  - Implemented Finite Difference normal calculation as a high-quality fallback when "Derivative Trick" is disabled.
  - Added "Octaves" parameter to control wave detail.
  - Refined reflection logic to handle stars and sun disk properly.

- **System**:
  - Updated [simulated_skybox.mat](cci:7://file:///Users/mathias/sources/git/filament/docs_src/src_raw/wip/sky/simulated_skybox.mat:0:0-0:0) with new material parameters (`starControl`, `waterControl`).
  - Refactored JS bindings in [SimulatedSkybox.js](cci:7://file:///Users/mathias/sources/git/filament/docs_src/src_raw/wip/sky/SimulatedSkybox.js:0:0-0:0) and organized `main.js` UI into logical folders.

DOCS_FORCE
2026-01-23 01:06:07 -08:00
Filament Bot 7fd9e728ae [automated] Updating /docs due to commit b66736b
Full commit hash is b66736b8cc

DOCS_ALLOW_DIRECT_EDITS
2026-01-22 23:23:09 +00:00
Powei Feng b66736b8cc docs: move wip skybox demo to /docs_src/src_raw (#9626)
/docs content is overwritten by content in /docs_src

(This tag will force a regeneration)
DOCS_FORCE
2026-01-22 23:20:10 +00:00
Doris Wu ea8f6a3c92 return empty string for es2 (#9623) 2026-01-22 14:49:54 -08:00
Doris Wu adcdbb45f9 fix typo (#9625) 2026-01-22 14:49:38 -08:00
Mathias Agopian cff958587d initialize VirtualMachineEnv on the right thread (#9624)
PerformanceHint manager needs a java thread during initialization,
so we need to attach a jvm to the thread that's going to be used.
That thread is the filament backend thread, not necessarily the thread 
the platform is created on.

So we make sure to do that from the backend thread.


FIXES=[427945768]
2026-01-22 10:24:39 -08:00
Mathias Agopian 9ab2326f15 some work in progress sample 2026-01-22 00:50:35 -08:00
Anish Goyal 8785acd352 Fix push constants with ext sampler (VK) (#9445)
Currently, in Vulkan, we set the pipeline layout when binding the
pipeline, which doesn't happen until draw time when external samplers
are present. In cases like that, we push constants with the layout
VK_NULL_HANDLE, which is not valid. Instead, we can wait until the
pipeline layout is known, and then flush all push constants.
2026-01-22 08:15:20 +00:00
Mathias Agopian 57767b7f27 Fix buffer overflow in RenderPass command batching (#9619)
The command batching logic in RenderPass::Executor::execute calculates a
conservative `maxCommandSizeInBytes` to determine how many commands can
safely fit in the driver's circular buffer.

However, this calculation failed to account for the dynamic memory
allocation incurred by the Per-Material descriptor set binding (via
`MaterialInstance::use`). This binding allocates a `DescriptorSetOffsetArray`
in the command stream, which was unbudgeted.

In scenarios with frequent material and scissor changes, the accumulated
deficit from these unbudgeted allocations could exceed the buffer 
capacity, leading to a crash.

This change:
1. Adds the missing accounting for the Per-Material dynamic allocation 
   to `maxCommandSizeInBytes`.
2. Adds a 20% safety margin to the calculated size to robustly handle
   alignment padding and worst-case scenarios.


FIXES=[474264976]
2026-01-21 21:03:49 -08:00
Powei Feng febcfc8f2d fgviewer: add info in panel for render passes (#9618)
- Add plumbing to add more information about rendertargets
   (including discard flags and pass id) to the fgviewer pass
   struct.
 - Add UI to display information about a selected pass
 - Highlight a selected resource or pass
2026-01-22 03:39:20 +00:00
Filament Bot c04c387a89 [automated] Updating /docs due to commit 78ac946
Full commit hash is 78ac9467f8

DOCS_ALLOW_DIRECT_EDITS
2026-01-22 03:05:41 +00:00
Sungun Park 78ac9467f8 Release Filament 1.68.5 2026-01-21 19:01:22 -08:00
Romain Guy 73b60d4db8 Add a new tone mapper (#9614)
The new tone mapper, dubbed "GT7" in the code, is based on
the Gran Turismo 7 tone mapper, as described in the SIGGRAPH
2025 presentation called "Driving Toward Reality: Physically
Based Tone Mapping and Perceptual Fidelity in Gran Turismo 7".

This tone mapper exhibits fewer hue skews than the other tone
mappers, at the exception of PBR Neutral. The GT7 tone mapper
is however better at preserving the perception of high
dynamic range.

The tone mapper, as implemented, targets an SDR paper white
of 250 nits, using 100 cd/m^2 as the reference luminance (for
values of 1.0 in the linear HDR framebuffer). This can result
in an overall darker image compared to the other tone mappers
but this can be controlled through camera settings, post-
processing exposure, or lighting intensity.

The GT7 tone mapper also allows to target HDR output, and
could be made customizable via APIs if desired. The current
implementation offers a fixed aesthetic solution.
2026-01-21 17:31:27 -08:00