mirror of
https://github.com/syoyo/tinygltf.git
synced 2026-08-04 12:28:53 +00:00
- always check Parameter::number_value to catch user errors, e.g. setting number_value without setting has_number_value, which will cause it to serialize as a bool but read back in as a float anyway
This commit is contained in:
@@ -1245,9 +1245,8 @@ bool Parameter::operator==(const Parameter &other) const {
|
||||
this->has_number_value != other.has_number_value)
|
||||
return false;
|
||||
|
||||
if (this->has_number_value)
|
||||
if (!TINYGLTF_DOUBLE_EQUAL(this->number_value, other.number_value))
|
||||
return false;
|
||||
if (!TINYGLTF_DOUBLE_EQUAL(this->number_value, other.number_value))
|
||||
return false;
|
||||
|
||||
if (this->json_double_value.size() != other.json_double_value.size())
|
||||
return false;
|
||||
|
||||
Reference in New Issue
Block a user