Scarfski/tinygltf
1
0
Fork 0
mirror of https://github.com/syoyo/tinygltf.git synced 2026-08-08 22:29:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow parsing integer number value as double(For example, glTF-Sample-Models/2.0/Cameras/glTF has zfar number property with integer value, which trigerred a parsing failure).

Browse Source
This commit is contained in:
Syoyo Fujita
2019-10-30 15:16:34 +09:00
parent 07d4fa0798
commit 61e9c396b9
1 changed files with 6 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tiny_gltf.h
View File

@@ -2567,23 +2567,16 @@ bool GetInt(const json &o, int &val) {
#endif
}
bool GetDouble(const json &o, double &val) {
#ifdef TINYGLTF_USE_RAPIDJSON
bool GetDouble(const json &o, double &val) {
if (o.IsDouble()) {
val = o.GetDouble();
return true;
}
return false;
#else
if (o.type() == json::value_t::number_float) {
val = static_cast<double>(o.get<double>());
return true;
}
return false;
#endif
}
#endif
bool GetNumber(const json &o, double &val) {
#ifdef TINYGLTF_USE_RAPIDJSON
@@ -2961,10 +2954,10 @@ static bool ParseNumberProperty(double *ret, std::string *err, const json &o,
return false;
}
double doubleValue;
bool isDouble = GetDouble(GetValue(it), doubleValue);
double numberValue;
bool isNumber = GetNumber(GetValue(it), numberValue);
if (!isDouble) {
if (!isNumber) {
if (required) {
if (err) {
(*err) += "'" + property + "' property is not a number type.\n";
@@ -2974,7 +2967,7 @@ static bool ParseNumberProperty(double *ret, std::string *err, const json &o,
}
if (ret) {
(*ret) = doubleValue;
(*ret) = numberValue;
}
return true;