Syoyo Fujita
354c1146ee
Fix possible nullptr dereferencing.
...
Add missing `return false`
2023-12-04 22:50:49 +09:00
Syoyo Fujita
fb3ff961f8
Merge pull request #465 from ptc-tgamper/bug/issue464
...
Fix Empty scenes are wrongly serialized as null Issue #464
2023-11-23 23:28:39 +09:00
Thomas Gamper
cef28f1791
Fix #464
...
tinygltf.h - serialize empty scenes as empty json objects; tester.cc - ad respective test case, bring test cases in correct order, tag test case for light index with correct issue number and fix it to compare to deserialozed model
2023-11-23 15:14:46 +01:00
Syoyo Fujita
cb4dcef520
Merge pull request #463 from ptc-tgamper/bug/issue458
...
Fix Light reference in the node issue #457
2023-11-23 22:19:05 +09:00
Thomas Gamper
46a1e426d1
fix #457
...
tiny_gltf.h - access correct json object when serializing a light, this fixes an assert and causes us to serialze the light index properly; tester.cc - add respective testcase
2023-11-23 14:13:12 +01:00
Syoyo Fujita
f54bbd847e
Merge pull request #462 from ptc-tgamper/bug/issue457
...
Fix Empty nodes are wrongly serialized as null Issue #457
2023-11-23 21:52:47 +09:00
Thomas Gamper
439d103665
fix #457
...
tiny_gltf.h - make sure to serialize null node as empty object; tester.cc - add respective test case
2023-11-23 11:59:18 +01:00
Syoyo Fujita
a65d2d6de1
Merge pull request #460 from ptc-tgamper/bug/issue459
...
Fix Default constructed Material has wrong emissiveFactor #459
2023-11-23 02:21:28 +09:00
Thomas Gamper
d66d9d291b
fix #459
...
tiny_gltf.h - use member initialization
2023-11-22 15:59:13 +01:00
Thomas Gamper
925d783330
fix #459
...
tiny_gltf.h - properly initialise emissiveFactor; tests/tester.cc - add test case
2023-11-22 14:17:46 +01:00
Syoyo Fujita
817ce1a9d0
Merge pull request #456 from haroonq/patch-1
...
Allow BufferView indices to be unspecified.
2023-10-10 21:24:51 +09:00
haroonq
8036d6a00f
Allow BufferView indices to be unspecified.
...
Allow BufferView indices for element array buffers to be unspecified to support some extensions.
Note that this is similar to how invalid array buffers are handled in order to support, for example, sparse morph targets.
2023-10-09 10:30:25 +00:00
Syoyo Fujita
e525653fbd
Merge pull request #455 from nyalldawson/fix_message
...
Fix incorrect component type shown in warning message
2023-09-12 20:28:35 +09:00
Nyall Dawson
1fc0f8056d
Fix incorrect component type shown in warning message
2023-09-12 08:46:14 +10:00
Syoyo Fujita
d7449cc0d6
Remove unused code. Fixes #454
2023-09-07 22:03:46 +09:00
Syoyo Fujita
616604c5c5
Merge pull request #453 from nyalldawson/fix_draco
...
Fix build with draco
2023-09-07 21:35:55 +09:00
Nyall Dawson
7db1b126b8
Fix build with draco
2023-09-07 08:20:28 +10:00
Syoyo Fujita
9f4ac79720
Merge pull request #452 from nyalldawson/permissive_align
...
Relax bin chunk end alignment check in permissive mode
2023-09-07 06:46:11 +09:00
Nyall Dawson
e387e3a221
Relax bin chunk end alignment check in permissive mode
2023-09-07 07:08:26 +10:00
Syoyo Fujita
0e5a1c9be9
Merge pull request #450 from nyalldawson/fix_win
...
Fix msvc build -- STRICT is a msvc macro name
2023-09-07 05:59:12 +09:00
Nyall Dawson
7f514ca27b
Fix msvc build -- STRICT is a msvc macro name
2023-09-07 06:28:37 +10:00
Syoyo Fujita
706cfb4cde
Merge pull request #451 from nyalldawson/mingw
...
Add mingw msys2 workflow
2023-09-06 20:55:14 +09:00
Nyall Dawson
b4e5d07c9f
Add mingw msys2 workflow
2023-09-06 08:26:34 +10:00
Nyall Dawson
2aad0ce782
Fix warning when building without draco support
2023-09-03 09:04:56 +10:00
Syoyo Fujita
9977c05b4b
Merge pull request #449 from emimvi/consistent_byteOffset
...
Always use size_t for byte offsets
2023-09-03 02:20:35 +09:00
Syoyo Fujita
7b2ae68239
Merge pull request #447 from nyalldawson/draco_fix
...
Handle the situation where the recorded component type does not match the required type for the actual number of stored points
2023-09-03 02:17:12 +09:00
emimvi
8b24ce8f3a
Consistently use size_t for all byteOffset's
2023-09-02 09:39:53 +02:00
Nyall Dawson
3cf58eef43
When in permissive mode, handle the situation where the
...
recorded component type does not match the required type
for the actual number of stored points
This situation arises when decoding certain malformed files, most
notably it's seen in glb tiles from Google Earth's 3d tileset.
It's a port of the workaround used by Cesium native here:
d9172461e2/CesiumGltfReader/src/decodeDraco.cpp (L101)
2023-09-02 10:16:04 +10:00
emimvi
7dc9766ce1
Serialize byteOffset as size_t, avoiding cast
...
Fixes silently writing an overflowed int in the output file.
2023-09-02 00:11:41 +02:00
Syoyo Fujita
c94ffcfeb7
Merge pull request #445 from nyalldawson/permissive
...
Be tolerant when encountering emissiveFactor with array length 4
2023-09-01 23:10:29 +09:00
Nyall Dawson
285e87211c
Add method to set parsing strictness
2023-08-28 12:56:09 +10:00
Nyall Dawson
e65694cc7d
Raise a warning when encountering emissiveFactor with array length
...
of 4 instead of aborting the model loading
2023-08-28 12:46:44 +10:00
Syoyo Fujita
5d3c322e89
Merge pull request #446 from nyalldawson/fix_error
...
Fix misleading error message
2023-08-24 22:11:50 +09:00
Nyall Dawson
6c6e131792
Fix misleading error message
...
Avoids a confusing "Must have 4 bytes or more bytes, but got 4."
error.
2023-08-24 11:48:09 +10:00
Syoyo Fujita
c015b60ddd
Merge pull request #442 from turanszkij/release-1
...
added project link to readme
2023-08-07 18:32:30 +09:00
Turánszki János
9b5fe332a2
added project link to readme
2023-08-07 06:59:35 +02:00
Syoyo Fujita
737a0b57c6
Merge pull request #433 from dyollb/modernize
...
Modernize
2023-07-11 19:43:53 +09:00
Syoyo Fujita
fe42a91023
Merge pull request #436 from dimitri-tdg/bugfix_extensions_primitive
...
Fix issue when serializing extensions of a primitive
2023-07-10 23:30:40 +09:00
KUDELSKI Dimitri
ebbcdf999f
Fix issue when serializing extensions of a primitive
2023-07-10 15:13:09 +02:00
Syoyo Fujita
64a818821e
Merge pull request #435 from RE-Kovalev/release
...
MinGW _wfopen_s fix
2023-07-05 18:41:22 +09:00
R.E. Kovalev
7979314811
MinGW _wfopen_s fix
2023-07-05 09:11:57 +03:00
Bryn Lloyd
879cf43bab
cppcoreguidelines-prefer-member-initializer
2023-06-21 22:30:14 +02:00
Bryn Lloyd
0817693edd
modernize-use-equals-default
2023-06-21 22:15:49 +02:00
Bryn Lloyd
4f9e144547
readability-redundant-string-init
2023-06-21 18:42:24 +02:00
Bryn Lloyd
210d56b07f
modernize-use-default-member-init
2023-06-21 18:40:18 +02:00
Bryn Lloyd
d955fd38e7
minor cleanup of cmakelists
2023-06-21 18:26:43 +02:00
Syoyo Fujita
927457b104
Initialize light and emitter members. Fixes #431
...
Include `light` and `emitter` comparison in Node::operator==()
2023-06-19 21:52:13 +09:00
Syoyo Fujita
1fcfcaeaca
Merge pull request #429 from AdamFull/release
...
KHR_audio parsing support (ASCII only)
2023-06-13 21:40:45 +09:00
Baranob_Ilya
f082c5d6b3
Added parsing and serializing of audio emitters for scene (global sources)
2023-06-12 13:35:05 +04:00
Baranob_Ilya
d5c7d72786
Forgot to add KHR_audio to used extensions
2023-06-12 12:34:34 +04:00
