Merge pull request #415 from louwaque/release

Fix serialization of AnimationChannel::target_node when it is zero
2026-06-17 12:48:52 +00:00 · 2023-04-19 05:17:06 +09:00 · 2023-04-18 21:03:39 +02:00 · 2023-04-10 19:11:35 +09:00 · 2023-04-08 23:44:53 +02:00
1 changed files with 4 additions and 1 deletions
--- a/tiny_gltf.h
+++ b/tiny_gltf.h
@@ -301,6 +301,9 @@ class Value {
  }
  explicit Value(std::string &&s)
      : type_(STRING_TYPE), string_value_(std::move(s)) {}
+  explicit Value(const char *s) : type_(STRING_TYPE) {
+    string_value_ = s;
+  }
  explicit Value(const unsigned char *p, size_t n) : type_(BINARY_TYPE) {
    binary_value_.resize(n);
    memcpy(binary_value_.data(), p, n);
@@ -6967,7 +6970,7 @@ static void SerializeGltfAnimationChannel(const AnimationChannel &channel,
  {
    detail::json target;

-    if (channel.target_node > 0) {
+    if (channel.target_node >= 0) {
      SerializeNumberProperty("node", channel.target_node, target);
    }
Author	SHA1	Message	Date
Syoyo Fujita	5c06b7d03b	Merge pull request #415 from louwaque/release Fix serialization of AnimationChannel::target_node when it is zero	2023-04-19 05:17:06 +09:00
Loïc Escales	a75355b018	Fix serialization of AnimationChannel::target_node when it is zero	2023-04-18 21:03:39 +02:00
Syoyo Fujita	a977f7a16f	Merge pull request #412 from agnat/add_char_pointer_ctor Fix #411 by adding a Value(const char *) constructor.	2023-04-10 19:11:35 +09:00
David Siegel	49caa65177	Fix #411 by adding a Value(const char *) constructor. Avoid implicit conversion of pointers to bool. Closes #411.	2023-04-08 23:44:53 +02:00