Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-09-01 16:08:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create external backtrace states from openable paths only.

Browse Source 
backtrace_create_state_for_file opens the file lazily on first use and,
on a failed open, silently falls back to /proc/self/exe - so a state
created from a path the monitor cannot open would symbolize the target's
addresses against the monitor's own binary. Probe the target's root path
(and, for unlinked images, the mapping's map_files entry), and only
create a state for a path that actually opens.
This commit is contained in:
Bartosz Taudul
2026-08-30 16:15:01 +02:00
parent 2a40f6f990
commit 2e566513dd
1 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
public/client/TracyCallstack.cpp
View File

@@ -587,7 +587,34 @@ static backtrace_state* GetExternalBtState( const ExternalImageEntry* entry )
auto* e = const_cast<ExternalImageEntry*>( entry );
if( e->btAttempted ) return e->btState;
e->btAttempted = true;
e->btState = backtrace_create_state_for_file( e->path, 0, ExternalBacktraceErrorCb, nullptr );
const size_t rootPathSize = strlen( e->path ) + 32;
char* rootPath = (char*)tracy_malloc( rootPathSize );
const char* statePath = nullptr;
char mfPath[80];
if( MakeExternalTargetPath( rootPath, rootPathSize, e->path ) >= 0 )
{
const int probe = open( rootPath, O_RDONLY );
if( probe >= 0 )
{
close( probe );
statePath = rootPath;
}
}
if( !statePath )
{
snprintf( mfPath, sizeof( mfPath ), "/proc/%d/map_files/%lx-%lx", (int)s_externalTargetPid, (unsigned long)e->startAddress, (unsigned long)e->endAddress );
const int probe = open( mfPath, O_RDONLY );
if( probe >= 0 )
{
close( probe );
statePath = mfPath;
}
}
if( statePath )
{
e->btState = backtrace_create_state_for_file( statePath, 0, ExternalBacktraceErrorCb, nullptr );
}
tracy_free( rootPath );
return e->btState;
}