Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-06-08 00:23:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Batch addr2line invocations by command-line length

Browse Source 
The fixed batches of 1024 addresses could overflow the platform's command-line limit (`La ligne de commande est trop longue.` from cmd.exe on Windows, whose limit is ~8191 characters). Build each batch by appending addresses until a length budget is reached instead. A single conservative budget of 8000 stays under the smallest limit on every platform, and keeps batches in the same ballpark as before (several hundred addresses per invocation).
This commit is contained in:
Clément Grégoire
2026-06-05 10:00:10 +02:00
parent 55d5436fb9
commit 7cb98245ce
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
update/src/OfflineSymbolResolverAddr2Line.cpp
View File

@@ -129,22 +129,30 @@ public:
std:: string escapedPath;
escapeShellParam( imagePath, escapedPath );
// Command-line length limits: cmd.exe (used by _popen on Windows) allows ~8191 characters;
// a single POSIX 'sh -c' argument is capped by MAX_ARG_STRLEN (128 KiB on Linux).
// 8000 stays under all of these, so a single conservative budget works on every platform.
const size_t maxCmdLength = 8000;
size_t entryIdx = 0;
while( entryIdx < inputEntryList.size() )
{
const size_t startIdx = entryIdx;
const size_t batchEndIdx = std::min( inputEntryList.size(), startIdx + (size_t)1024 );
printf( "Resolving symbols [%zu-%zu]\n", startIdx, batchEndIdx );
// generate a single addr2line cmd line for all addresses in one invocation
// generate a single addr2line cmd line for as many addresses as fit the length budget
std::stringstream ss;
ss << m_addr2LinePath << " -C -f" << m_addr2LineArgs << " -e " << escapedPath << " -a ";
for( ; entryIdx < batchEndIdx; entryIdx++ )
while( entryIdx < inputEntryList.size() )
{
const FrameEntry& entry = inputEntryList[entryIdx];
ss << " 0x" << std::hex << entry.symbolOffset;
entryIdx++;
// always include at least one address, then stop once near the length limit
if( static_cast<size_t>( ss.tellp() ) >= maxCmdLength ) break;
}
const size_t batchEndIdx = entryIdx;
printf( "Resolving symbols [%zu-%zu]\n", startIdx, batchEndIdx );
std::string cmd = ss.str();
#ifdef _WIN32