Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-08-21 18:48:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ignore the statistics range filter in the disassembly LLM tool.

Browse Source 
The symbol disassembly tool scoped its cost data to the statistics
range filter. This is invisible UI state which the model cannot see, so
range-limited numbers were indistinguishable from whole-trace figures
and could silently change between tool calls. The other sampling tools
always report whole-trace data; do the same here.
This commit is contained in:
Bartosz Taudul
2026-07-25 22:22:49 +02:00
parent a429242f0f
commit c2c1c4e2b7
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
profiler/src/profiler/TracyDisassembly.cpp
View File

@@ -717,20 +717,21 @@ nlohmann::json JsonDisassembly( uint64_t symAddr, Worker& worker, const View& vi
auto data = Disassemble( symAddr, worker );
if( data.lines.empty() ) return nlohmann::json { { "error", "Disassembly failed" } };
const bool limitView = view.GetRange( RangeId::Statistics ).active;
// Tool calls always operate on the whole trace. The statistics range filter is
// invisible UI state, which would silently scope the reported costs.
AddrStatData as;
GatherIpStats( symAddr, as, worker, limitView, view, nullptr, false );
GatherIpStats( symAddr, as, worker, false, view, nullptr, false );
auto iptr = worker.GetInlineSymbolList( symAddr, data.codeLen );
if( iptr )
{
const auto symEnd = symAddr + data.codeLen;
while( *iptr < symEnd )
{
GatherIpStats( *iptr, as, worker, limitView, view, nullptr, false );
GatherIpStats( *iptr, as, worker, false, view, nullptr, false );
iptr++;
}
}
GatherAdditionalIpStats( symAddr, as, worker, limitView, view, nullptr, false );
GatherAdditionalIpStats( symAddr, as, worker, false, view, nullptr, false );
char tmp[32];
sprintf( tmp, "0x%" PRIx64, symAddr );