Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-10-02 23:15:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not crash on missing symbol data in sample entry stacks window.

Browse Source 
The window can be opened for a symbol which has no symbol stats or no
symbol data. For example, the statistics window can produce clickable
rows for symbols that are not present in the symbol map. Close the
window instead of dereferencing null pointers.
This commit is contained in:
Bartosz Taudul
2026-07-25 18:41:46 +02:00
parent bacfbccb97
commit d5760a05ae
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
profiler/src/profiler/TracyView_Samples.cpp
View File

@@ -839,6 +839,14 @@ void View::DrawSamplesStatistics( Vector<SymList>& data, int64_t timeRange, Accu
void View::DrawSampleParents()
{
const auto ss = m_worker.GetSymbolStats( m_sampleParents.symAddr );
const auto symbol = m_worker.GetSymbolData( m_sampleParents.symAddr );
if( !ss || !symbol )
{
m_sampleParents.symAddr = 0;
return;
}
bool show = true;
const auto scale = GetScale();
ImGui::SetNextWindowSize( ImVec2( 1400 * scale, 500 * scale ), ImGuiCond_FirstUseEver );
@@ -846,10 +854,8 @@ void View::DrawSampleParents()
ImGui::Begin( "Sample entry stacks", &show, ImGuiWindowFlags_NoScrollbar | ImGuiWindowFlags_NoScrollWithMouse );
if( !ImGui::GetCurrentWindowRead()->SkipItems )
{
auto ss = m_worker.GetSymbolStats( m_sampleParents.symAddr );
if( m_sampleParents.statMode == 0 && ss->wasExecuting.empty() ) m_sampleParents.statMode = 1;
const auto symbol = m_worker.GetSymbolData( m_sampleParents.symAddr );
uint64_t total = 0;
unordered_flat_map<uint32_t, uint32_t> stats;
if( m_sampleParents.statMode == 0 )