Scarfski/tracy
1
0
Fork 0
mirror of https://github.com/wolfpld/tracy.git synced 2026-09-10 20:38:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add function to calculate thread lock wait time in TracyTimelineItemThread

Browse Source 
This update introduces a new function, GetThreadLockWaitTime, which computes the total wait time for locks held by a specific thread. The function aggregates wait times across all locks and updates the tooltip to display lock wait time and count, enhancing the profiling capabilities of the timeline item.
This commit is contained in:
David McCloskey
2026-07-23 14:21:54 -05:00
parent 917c4baffb
commit ea3d0b4d8d
1 changed files with 53 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
profiler/src/profiler/TracyTimelineItemThread.cpp
View File

@@ -17,6 +17,45 @@ namespace tracy
constexpr float MinVisSize = 3;
constexpr float MinCtxSize = 4;
// Sum Wait→Obtain (and WaitShared→ObtainShared) for one thread across all locks.
static int64_t GetThreadLockWaitTime( const Worker& worker, uint64_t tid, size_t& lockCnt, uint64_t& waitCount )
{
int64_t waitTotal = 0;
lockCnt = 0;
waitCount = 0;
for( const auto& lock : worker.GetLockMap() )
{
const auto& lockmap = *lock.second;
if( !lockmap.valid ) continue;
auto it = lockmap.threadMap.find( tid );
if( it == lockmap.threadMap.end() ) continue;
lockCnt++;
const uint8_t thread = it->second;
bool pending = false;
int64_t waitStart = 0;
for( const auto& evPtr : lockmap.timeline )
{
const auto* ev = evPtr.ptr.get();
if( !ev || ev->thread != thread ) continue;
if( ev->type == LockEvent::Type::Wait || ev->type == LockEvent::Type::WaitShared )
{
pending = true;
waitStart = ev->Time();
}
else if( ev->type == LockEvent::Type::Obtain || ev->type == LockEvent::Type::ObtainShared )
{
if( pending )
{
waitTotal += ev->Time() - waitStart;
waitCount++;
pending = false;
}
}
}
}
return waitTotal;
}
TimelineItemThread::TimelineItemThread( View& view, Worker& worker, const ThreadData* thread )
: TimelineItem( view, worker, thread, true )
@@ -171,14 +210,8 @@ void TimelineItemThread::HeaderTooltip( const char* label ) const
ImGui::Separator();
size_t lockCnt = 0;
for( const auto& lock : m_worker.GetLockMap() )
{
const auto& lockmap = *lock.second;
if( !lockmap.valid ) continue;
auto it = lockmap.threadMap.find( m_thread->id );
if( it == lockmap.threadMap.end() ) continue;
lockCnt++;
}
uint64_t lockWaitCount = 0;
const int64_t lockWaitTime = GetThreadLockWaitTime( m_worker, m_thread->id, lockCnt, lockWaitCount );
if( last >= 0 )
{
@@ -200,6 +233,18 @@ void TimelineItemThread::HeaderTooltip( const char* label ) const
PrintStringPercent( buf, ctx->runningTime / double( lifetime ) * 100 );
TextDisabledUnformatted( buf );
}
if( lockCnt != 0 || lockWaitTime > 0 )
{
TextFocused( "Lock wait time:", TimeToString( lockWaitTime ) );
ImGui::SameLine();
PrintStringPercent( buf, lockWaitTime / double( lifetime ) * 100 );
TextDisabledUnformatted( buf );
if( lockWaitCount != 0 )
{
ImGui::SameLine();
ImGui::TextDisabled( "(%s waits)", RealToString( lockWaitCount ) );
}
}
}
ImGui::Separator();