Commit Graph
5976 Commits
Author SHA1 Message Date
Bartosz Taudul b4c1313a2e Make hw stats cost a parameter. 2021-07-18 02:03:29 +02:00
Bartosz Taudul 50f7deb1a3 Merge pull request #243 from benvanik/patch-4
Indenting empty GPU zone tree nodes when grouped to keep zones aligned.
2021-07-17 20:48:43 +02:00
Ben Vanik ba185b18f9 Indenting empty grouped CPU/GPU zone tree nodes to keep things aligned. 2021-07-17 11:46:29 -07:00
Bartosz Taudul 4f3195153a Merge pull request #242 from benvanik/patch-3
Fixing unbalanced tree pop in grouped GPU zones.
2021-07-17 20:03:41 +02:00
Ben Vanik e3165c333b Fixing unbalanced tree pop in grouped GPU zones. 2021-07-17 09:25:44 -07:00
Bartosz Taudul ef2a25319c Update NEWS. 2021-07-11 19:46:02 +02:00
Bartosz Taudul edae542a48 Allow selecting image name for filtering from a list. 2021-07-11 19:43:51 +02:00
Bartosz Taudul b6db644ac6 Add hasher and comparator for StringIdx. 2021-07-11 19:43:40 +02:00
Bartosz Taudul d6835f3a7a Use correct language version for library. 2021-07-07 02:45:13 +02:00
Bartosz Taudul 0affc27abf Merge pull request #238 from rokopt/non-reentrant-time-manual-fix
Update manual to reflect timing-mode GUI changes
2021-06-27 17:35:07 +02:00
Terence Rokop c51e4fd11d Update manual to reflect timing-mode GUI changes 2021-06-26 17:23:54 -07:00
Bartosz Taudul 6ddb24f57f Update AUTHORS. 2021-06-26 22:53:02 +02:00
Bartosz Taudul 9f185310be Merge pull request #230 from rokopt/recursive-zone-timings
Introduce "non-reentrant time" statistics view
2021-06-26 21:17:45 +02:00
Terence Rokop 68ec7abdf4 Move responsibility for spacing of combo box
Thereby fix a spurious horizontal separator bar.
2021-06-26 11:51:57 -07:00
Terence Rokop d6fd252ce4 Add more spacing to pre-existing options 2021-06-26 10:41:24 -07:00
Terence Rokop e105d2d96c Aesthetic fixes to accumulation mode combo box
Shorter text fields and more spacing.
2021-06-26 10:41:23 -07:00
Terence Rokop 1dd117533e Avoid non-reentrant option in sampling/symbol view 2021-06-26 10:41:23 -07:00
Terence Rokop f000dce73f Replace "enum class" switches with explicit casts 2021-06-26 08:30:15 -07:00
Terence Rokop d6761c2ffa Update manual for accumulation mode combo box 2021-06-25 21:33:12 -07:00
Terence Rokop b392671a7a Make time accumulation mode use combo box 2021-06-25 21:27:45 -07:00
Bartosz Taudul 2e466852ac Merge pull request #237 from ilmai/master
Add meson.build
2021-06-24 22:02:32 +02:00
Jussi Viiri fbed24dc0f Add meson.build 2021-06-24 22:41:50 +03:00
Bartosz Taudul 9a22b8e83c Cosmetics. 2021-06-23 20:43:46 +02:00
Bartosz Taudul 913463635a Cosmetics. 2021-06-23 20:37:14 +02:00
Terence Rokop 894c90f867 Update manual with new non-reentrant-time option 2021-06-20 18:00:47 -07:00
Terence Rokop 9366e58d12 Introduce "Non-reentrant time" radio button
Add to the statistics view an option for "Non-reentrant
time", which displays the count of and time spent in zone
events which were the only appearances (at that time) of
their zones on their threads' stacks.

Besides the GUI changes, this involves:

- Introducing a tri-state accumulation mode to replace the
boolean "self time":  now there's "Self time only",
"Child time", and "Non-reentrant time".

- Removing the separate "selfTotal" from SrcLocZonesSlim,
making "total" represent whichever of the now three options
is active, which in turn requires keeping track of the
accumulation mode in StatisticsCache and invalidating that
cache when the accumulation mode changes.
2021-06-20 17:56:15 -07:00
Terence Rokop 66053e37f7 Add non-reentrant stats to SourceLocationZones
Extend SourceLocationZones with fields to track the count
and time of non-reentrant zone events -- that is, zone
events which were the only appearances (at the time) of
those zones on their threads' stacks.
2021-06-20 17:56:15 -07:00
Terence Rokop c90e39e06e Keep track of zone appearances on thread stacks
Start keeping track, using the previously-introduced
SrcLocCountMap, of the number of appearances of each zone
on each thread's stack at a given time.
2021-06-20 17:56:15 -07:00
Terence Rokop 1f0b4656f4 Introduce SrcLocCountMap
Add to ThreadData a map from source location to a counter,
which will be used to keep track of the number of
appearances of zones with the corresponding source locations
on each thread's stack.
2021-06-20 17:56:14 -07:00
Terence Rokop 0a8ec09566 Introduce View::IsZoneReentry()
These two methods can search a timeline to determine whether
a given ZoneEvent is the only appearance of the given zone
on the current thread stack, or a re-entry.
2021-06-20 17:53:38 -07:00
Bartosz Taudul 32b1e8dcb0 No kernel symbol on macos. 2021-06-20 19:35:05 +02:00
Bartosz Taudul 759dd39f77 Update manual. 2021-06-20 19:18:36 +02:00
Bartosz Taudul 0e0692b7f7 Don't display hw samples as time in selected lines summary. 2021-06-20 16:01:19 +02:00
Bartosz Taudul e9aca02880 Make hw sample cost in source files relative to whole symbol. 2021-06-20 15:55:21 +02:00
Bartosz Taudul 846bde1a11 Narrow down search range. 2021-06-20 14:37:56 +02:00
Bartosz Taudul 15b42039bd Add very early exit test. 2021-06-20 14:34:47 +02:00
Bartosz Taudul d4b92e0fbe Add early exit conditions. 2021-06-20 14:33:08 +02:00
Bartosz Taudul a10d71b766 Switch loop order for better cache locality on the slow path. 2021-06-20 14:30:55 +02:00
Bartosz Taudul a9a16b4d94 Narrow down search region. 2021-06-20 14:24:42 +02:00
Bartosz Taudul 22352dd29b Select optimized path before entering loop. 2021-06-20 14:22:14 +02:00
Bartosz Taudul 5d86002f82 Calculate all CPU usage values in one go. 2021-06-20 14:19:18 +02:00
Bartosz Taudul 5efc03cdf9 Move cycles up in cost combo selector. 2021-06-20 12:50:13 +02:00
Bartosz Taudul c445c3805c Merge remote-tracking branch 'origin/master' into hw 2021-06-20 11:13:02 +02:00
Bartosz Taudul d90758e92d Merge pull request #235 from avoroshilov/fix-compilation-warning
Fix compilation warning
2021-06-20 10:57:17 +02:00
Andrey Voroshilov 5670493757 Fix compilation warning 2021-06-19 23:26:03 -07:00
Bartosz Taudul 13c103065a Update NEWS. 2021-06-20 01:17:38 +02:00
Bartosz Taudul 7e17c8643c Don't show hw events as time. 2021-06-20 01:08:18 +02:00
Bartosz Taudul bc4016e97c Don't depend on callstack frames to match hw samples to source. 2021-06-20 01:01:29 +02:00
Bartosz Taudul 2f3ee594f0 Use square root to make slow branches and cache less spiky. 2021-06-20 00:50:14 +02:00
Bartosz Taudul 3305ea2775 Keep raw hw sample data visually separate. 2021-06-20 00:46:29 +02:00