Scarfski/filament
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak (#6056)

Browse Source 
This change fixes #6055
This commit is contained in:
Romain Guy
2022-09-08 20:57:46 -07:00
committed by GitHub
parent 5e128214fa
commit eaa86060e2
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
samples/image_viewer.cpp
View File

@@ -215,7 +215,7 @@ static void createImageRenderable(Engine* engine, Scene* scene, App& app) {
app.scene.defaultTexture = texture;
}
static void loadImage(App& app, Engine* engine, Path filename) {
static void loadImage(App& app, Engine* engine, const Path& filename) {
if (app.scene.imageTexture) {
engine->destroy(app.scene.imageTexture);
app.scene.imageTexture = nullptr;
@@ -260,7 +260,8 @@ static void loadImage(App& app, Engine* engine, Path filename) {
size_t(w * h * channels * sizeof(float)),
channels == 3 ? Texture::Format::RGB : Texture::Format::RGBA,
Texture::Type::FLOAT,
freeCallback
freeCallback,
image
);
texture->setImage(*engine, 0, std::move(buffer));
@@ -351,10 +352,10 @@ int main(int argc, char** argv) {
if (app.showImage) {
Texture *texture = app.scene.imageTexture;
float srcWidth = texture->getWidth();
float srcHeight = texture->getHeight();
float dstWidth = view->getViewport().width;
float dstHeight = view->getViewport().height;
float srcWidth = (float) texture->getWidth();
float srcHeight = (float) texture->getHeight();
float dstWidth = (float) view->getViewport().width;
float dstHeight = (float) view->getViewport().height;
float srcRatio = srcWidth / srcHeight;
float dstRatio = dstWidth / dstHeight;